Opened on 02/22/2017 at 02:33:09 PM
Closed on 06/26/2017 at 02:01:22 PM
#4920 closed change (fixed)
Add "Ready for Windows" section to adblockplus.org
| Reported by: | oleksandr | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | saroyanm, julian, jeen, lisabielik, jnink, athornburgh | Blocked By: | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Background
We would like to get certified for Ready for Windows. To do that we need to have a statement on our website that our ABP for IE does indeed support Windows 10. There is more info about the requirement here
What to change
Add this text to IE specific page:
Adblock Plus for Internet Explorer is supported by eyeo GmbH on the following editions of Windows 10 – Windows 10 Pro, Windows 10 Education and Windows 10 Enterprise. Adblock Plus for Internet Explorer is supported on the in-market supported servicing branches of Windows 10 including - Current Branch, Current Branch for Business and the following Long-Term Servicing branch: Windows 10.
Approvals
[x] Content
[x] Legal
[x] Product
Attachments (1)
Change History (23)
comment:1 Changed on 02/22/2017 at 02:39:57 PM by saroyanm
- Cc jeen lisabielik jnink added
comment:2 Changed on 02/23/2017 at 12:44:06 PM by jeen
Trying to understand this - can this be anywhere on the website? Are there any restrictions on where this has to be displayed?
I.e. can we add this to our terms of use (@jnink - is this is even the relevant place for it? Maybe it should go somewhere else?)
The most relevant IE specific area on the current website is within the Learn More expandable area on the homepage. However, we are redesigning the homepage and this section will be removed. Therefore, I'm trying to understand if there is a better place we could be putting browser-specific information and if there is any other browser-specific information I should be aware of?
comment:3 Changed on 02/24/2017 at 11:36:30 AM by jnink
@jeen: Let's keep it out of the terms of use. It is more a technical statement rather than a legal. They don't state any placement requirements but from my understanding it is something related to ABP itself. Thus, I recommend to include it somewhere on the download page.
comment:5 Changed on 02/24/2017 at 12:16:12 PM by jnink
Changed the statement text as aligned with @oleksandr. LGTM now.
comment:6 Changed on 03/08/2017 at 04:34:06 PM by juliandoucette
- Description modified (diff)
- Keywords goodfirstbug added
- Summary changed from Add text for "Ready for Windows" certification to adblockplus.org to Add "Ready for Windows" section to adblockplus.org
Added approvals. Please update if I missed something.
@Jeen I get the impression that he wants an IE only notice (like our fr only and maxthon only notices) on the homepage and other download pages.
comment:7 Changed on 03/08/2017 at 05:16:30 PM by lisabielik
Is 12:33 PM supposed to be in the last sentence?
comment:8 Changed on 03/15/2017 at 02:49:38 PM by oleksandr
- Description modified (diff)
No. Removed it. Thanks, Lisa.
comment:10 Changed on 03/28/2017 at 02:05:41 PM by lisabielik
@oleksandr @juliandoucette
Is there anything blocking this ticket?
comment:11 follow-up: ↓ 12 Changed on 03/29/2017 at 04:43:20 PM by juliandoucette
Is there anything blocking this ticket?
Design/Wireframes and product approval.
comment:12 in reply to: ↑ 11 Changed on 03/30/2017 at 01:57:43 PM by lisabielik
Replying to juliandoucette:
Is there anything blocking this ticket?
Design/Wireframes and product approval.
I thought this was just supposed to be a "note" added to the homepage? @Oleksandr, can you confirm?
Also adding Aaron to the ticket for the Product part.
comment:13 Changed on 03/30/2017 at 01:58:21 PM by lisabielik
- Cc athornburgh added
comment:14 Changed on 03/30/2017 at 02:00:37 PM by oleksandr
This is supposed to be just a note.
Changed on 03/30/2017 at 02:17:40 PM by jeen
comment:15 Changed on 03/30/2017 at 02:20:41 PM by jeen
I've just added a mockup - the notification should go just above the footer and be styled in the same way as the messaging for Adblock Browser.
Consider it approved by Product.
comment:16 Changed on 04/10/2017 at 04:07:28 PM by juliandoucette
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
Another fancy conditional homepage message!
@oleksandr I have prioritized this issue P3. Please let me know if you think it should be P2 (if you want to apply for Ready for Windows soon).
comment:17 Changed on 06/07/2017 at 02:15:00 PM by ire
- Owner set to iaderinokun
comment:18 Changed on 06/07/2017 at 03:00:37 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:19 Changed on 06/16/2017 at 06:04:33 PM by juliandoucette
Does this apply to IE and Edge or just IE?
comment:20 Changed on 06/16/2017 at 06:27:47 PM by oleksandr
This applies to IE only.
comment:21 Changed on 06/26/2017 at 02:00:20 PM by abpbot
A commit referencing this issue has landed:
Issue 4920 - Add "Ready for Windows" section to adblockplus.org
comment:22 Changed on 06/26/2017 at 02:01:22 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
I think this kind of requests should go through the product team first, CCing people that might be involved.