Opened on 05/15/2014 at 12:17:14 PM

Closed on 11/10/2017 at 11:15:18 AM

#493 closed change (rejected)

Validate custom filters in Firefox

Reported by: sebastian Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: smultron45@gmail.com Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

Currently you can add filters with invalid CSS selectors that lead to warnings when applied.

What to change

Make sure that the CSS selector of element hiding filters added by the user is valid. Otherwise reject saving them.

Attachments (0)

Change History (6)

comment:1 Changed on 05/15/2014 at 12:25:40 PM by mapx

  • Cc smultron45@gmail.com added

comment:2 Changed on 05/15/2014 at 03:09:40 PM by sebastian

  • Ready set

comment:3 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:4 Changed on 11/18/2014 at 03:48:45 PM by sebastian

  • Blocked By 1583 added

comment:5 Changed on 11/19/2014 at 01:36:22 PM by sebastian

  • Blocked By 1583 removed

comment:6 Changed on 11/10/2017 at 11:15:18 AM by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.