Opened on 05/15/2014 at 12:10:05 PM
Closed on 02/24/2016 at 01:43:28 AM
#492 closed change (rejected)
Implement content blockers to block popups and XMLHttpRequests on Safari
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | arthur | Blocked By: | |
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Popups and XMLHttpRequests aren't blocked on Safari, since this wasn't possible so far. However, Safari 9 introduces content blockers that lift these limitations. Though this mechanism has quite some other limitations and issues.
So we might want to stick to the old mechanism based on the beforeload DOM event for other means of request blocking, while using the new mechanism to block popups and XMLHttpRequests.
What to change
Use content blockers on Safari 9+ to block popups and XMLHttpRequests.
Attachments (0)
Change History (9)
comment:1 Changed on 05/15/2014 at 03:09:40 PM by sebastian
- Ready set
comment:2 Changed on 05/15/2014 at 03:59:36 PM by arthur
- Cc arthur added
comment:3 Changed on 05/16/2014 at 10:02:35 AM by sebastian
I tested following cases which are blocked by EasyList Germany:
- http://www.hifi-forum.de/viewthread-84-24338.html (click everywhere in the page)
- http://movie-blog.org/ (click on "Enter")
But we probably should test some more cases. Please also test popup blocking on Chrome, since that code has changed too (in order to share some code between Chrome and Safari).
comment:4 Changed on 05/16/2014 at 12:00:05 PM by arthur
Sure, will do once it's in the dev build.
comment:5 Changed on 07/09/2014 at 12:47:32 PM by philll
- Platform set to Safari
comment:6 Changed on 09/16/2015 at 06:54:13 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from reviewing to reopened
- Tester set to Unknown
I removed the patch. Beside it has been in review for almost 1.5 years without any progress, the new content blocking mechanism seems to be a better the way to go to implement popup blocking.
comment:7 Changed on 09/16/2015 at 07:03:48 AM by sebastian
- Description modified (diff)
- Owner sebastian deleted
- Priority changed from P3 to P4
- Summary changed from Implement popup blocking in Safari to Implement content blockers to block popups and XMLHttpRequests
comment:8 Changed on 09/16/2015 at 07:04:20 AM by sebastian
- Summary changed from Implement content blockers to block popups and XMLHttpRequests to Implement content blockers to block popups and XMLHttpRequests on Safari
Let me know if you need more example sites.