Opened on 02/24/2017 at 01:07:31 PM
Closed on 03/20/2017 at 12:22:25 PM
#4931 closed change (fixed)
add possibility to not send data depending on connection properties
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | fhd, anton, oleksandr | Blocked By: | #4944 |
| Blocking: | #4948 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We need an option to configure our engine to not use network in certain circumstances, e.g. when connection is metered.
Why in libadblockplus
Ideally it should be in adblockpluscore, however it will take too long to land it there but in libadblockplus we can get it done much faster and anyway we will have to have such API in libadblockplus.
What to change
Add method to JsEngine allowing to set a callback verifying whether the current connection is allowed or not. If this callback is empty then request is always allowed.
In calling network request method return error if method is not allowed.
Attachments (0)
Change History (6)
comment:1 Changed on 02/28/2017 at 11:55:37 AM by sergz
- Blocked By 4944 added
comment:2 Changed on 02/28/2017 at 02:36:19 PM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 02/28/2017 at 03:40:41 PM by oleksandr
- Cc oleksandr added
comment:4 Changed on 03/01/2017 at 08:45:52 AM by asmirnov
- Blocking 4948 added
comment:5 Changed on 03/20/2017 at 12:20:56 PM by abpbot
comment:6 Changed on 03/20/2017 at 12:22:25 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4931 - add possibility to not send data depending on connection properties