Opened on 02/24/2017 at 02:10:16 PM
Closed on 03/08/2017 at 03:12:12 PM
#4932 closed change (fixed)
Adjust repository permissions
Reported by: | sergz | Assignee: | fred |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | fhd, fred | Blocked By: | |
Blocking: | #4907 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
|
Description
Background
I need to update
- gyp
- googletest-github
- v8-googlesource
Observed
For one changeset:
hg push --debug abp -B abp-step-by-step-push pushing to ssh://hg@hg.adblockplus.org/v8-googlesource/ running "C:\Program Files\TortoiseHg\lib\TortoisePlink.exe" -ssh -2 hg@hg.adblockplus.org "hg -R v8-googlesource/ serve --stdio" sending hello command sending between command remote: 345 remote: capabilities: lookup changegroupsubset branchmap pushkey known getbundle unbundlehash batch stream bundle2=HG20%0Achangegroup%3D01%2C02%0Adigests%3Dmd5%2Csha1%2Csha512%0Aerror%3Dabort%2Cunsupportedcontent%2Cpushraced%2Cpushkey%0Ahgtagsfnodes%0Alistkeys%0Apushkey%0Aremote-changegroup%3Dhttp%2Chttps unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 remote: 1 query 1; heads sending batch command searching for changes all remote heads known locally preparing listkeys for "phases" sending listkeys command received listkey for "phases": 15 bytes checking for updated bookmarks preparing listkeys for "bookmarks" sending listkeys command received listkey for "bookmarks": 112 bytes sending branchmap command sending branchmap command preparing listkeys for "bookmarks" sending listkeys command received listkey for "bookmarks": 112 bytes 1 changesets found list of changesets: 701ef1dd90c06ba0adcec4e233a0f9108da5de33 sending unbundle command bundle2-output-bundle: "HG20", 5 parts total bundle2-output-part: "replycaps" 155 bytes payload bundle2-output-part: "check:heads" streamed payload bundle2-output-part: "changegroup" (params: 1 mandatory) streamed payload bundle2-output-part: "pushkey" (params: 4 mandatory) empty payload bundle2-output-part: "pushkey" (params: 4 mandatory) empty payload remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 2 changes to 2 files remote: v8-autoroll@chromium.org <v8-autoroll@chromium.org> remote: transaction abort! remote: rollback completed bundle2-input-bundle: with-transaction bundle2-input-part: "error:abort" (params: 1 mandatory) supported bundle2-input-bundle: 0 parts total remote: pretxnchangegroup.author_check hook exited with status 1 abort: push failed on remote }}}}
Attachments (0)
Change History (7)
comment:1 Changed on 03/01/2017 at 11:43:53 AM by fred
comment:2 Changed on 03/01/2017 at 12:42:26 PM by matze
- Summary changed from It's not possible to update repositories to Adjust repository permissions
- Type changed from defect to change
@fhd: ACK on elevating sergz permissions to include (global) [trusted] status in HG?
comment:3 Changed on 03/01/2017 at 12:57:18 PM by sergz
Why not to give access to only repos mentioned on https://adblockplus.org/modules where I'm the owner?
comment:4 Changed on 03/01/2017 at 01:51:58 PM by fhd
Why not to give access to only repos mentioned on https://adblockplus.org/modules where I'm the owner?
That is technically not possible, a user is either trusted globally, or not at all.
The main point behind [trusted] is that people don't accidentally configure their email address wrong :D I figure Sergei is beyond that point. Most module owners are trusted, so let's add Sergei as well. He'll need it to land patches contributed by others, too.
comment:5 Changed on 03/01/2017 at 04:00:39 PM by fred
- Owner set to fred
- Ready set
comment:6 Changed on 03/02/2017 at 04:42:50 PM by fred
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 03/08/2017 at 03:12:12 PM by fred
- Resolution set to fixed
- Status changed from reviewing to closed
What needs to be done:
The user "sergei" needs to have the "trusted" flag added to be able to push those changesets.