Exception thrown in popup window

[Ross]

Environment

Adblock Plus 1.12.4.1739
Chrome 49 / 56 / Windows 10
Opera 37 / 41 / Windows 7

How to reproduce

1. Install extension.
2. Inspect the popup and view the Console.

Observed behaviour

Javascript error related to notifications:
    Uncaught SyntaxError: Identifier 'require' has already been declared
    at notification.js:1

Expected behaviour

JS error to not occur.

Notes

The error being thrown in the popup's console is a regression caused by ​Issue 4795 - Use modern JavaScript syntax.

[kzar]

What did you do to test notifications? When I run this code in the background console:

require("notification").Notification.addNotification({
  id: new Date() | 0,
  type: "normal",
  title: "Notification title",
  message: "<a>Click</a> <a>Configure</a> <a>notification</a> <a>settings</a>",
  urlFilters: ["||example.com^$document"]
});

and then browse to ​http://example.com the notification is displayed. Also the button to open the options page from the notification worked for me.

I can reproduce the console error though, argh.

[Ross]

Ah okay, I was using the popup console instead of the background console. Notifications do work.

[kzar]

Thanks, marking this as ready.

[abpbot]

A commit referencing this issue has landed:
​Issue 4973 - Avoid redeclaring require in the popup