Opened on 03/10/2017 at 01:23:51 PM
Closed on 03/11/2017 at 11:42:36 AM
#4974 closed defect (fixed)
HTMLCollection iterator workaround for old Chrome versions missing from popup window
| Reported by: | Ross | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.13-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | kzar, trev, rraceanu | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
ABP 1.12.4.1739
Chrome 49 but not in 56.
Opera 37 but not in 41.
How to reproduce
- Install Adblock Plus
- Open popup, inspect and open Console.
Observed behaviour
JavaScript error is displayed:
Uncaught TypeError: document.getElementsByClassName(...)[Symbol.iterator] is not a function popup.js:78
Expected behaviour
JavaScript error not to occur.
Notes
HTMLCollection in older versions of Chrome does not have iterator support. We have a workaround in ext/common.js but we forgot to include that in the popup window too.
Attachments (0)
Change History (5)
comment:2 Changed on 03/10/2017 at 01:39:40 PM by kzar
- Cc trev added
- Component changed from Unknown to Platform
- Description modified (diff)
- Milestone set to Adblock-Plus-1.13-for-Chrome-Opera
- Owner set to kzar
- Priority changed from Unknown to P1
- Ready set
- Review URL(s) modified (diff)
- Summary changed from Popup.js error to HTMLCollection iterator workaround for old Chrome versions missing from popup window
comment:3 Changed on 03/10/2017 at 01:39:55 PM by kzar
- Status changed from new to reviewing
comment:4 Changed on 03/11/2017 at 11:33:57 AM by abpbot
comment:5 Changed on 03/11/2017 at 11:42:36 AM by kzar
- Cc rraceanu added
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4974 - Include HTMLCollection iterator workaround for popup