Opened on 03/17/2017 at 12:05:55 PM
Closed on 04/11/2017 at 11:11:20 AM
#5011 closed change (fixed)
Change Formmail2 To Fail When Template is Not Found
| Reported by: | jsonesen | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | kvas, sebastian, ferris | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kvas)
Background
Recently during the acceptable ads committee deployment a template file was not copied into the required sitescripts dir. This caused quiet failures for form submissions on the website for a number of hours.
Currently the template is not loaded until the handler has been invoked by the multiplexer. There's no performance penalty since the templates are cached, but it also means that we don't know if the proper template file exists until it is too late (i.e. when a user tries to submit form data).
What to change
Load the template at the creation of the handler so that if the template file does not exist the website will not deploy and will raise a 'jinja2.TemplateNotFound' exception which will include the path where the template file is expected to live.
Attachments (0)
Change History (6)
comment:1 Changed on 03/17/2017 at 02:32:33 PM by kvas
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 03/18/2017 at 09:14:01 AM by jsonesen
- Status changed from new to reviewing
comment:4 Changed on 04/11/2017 at 09:41:49 AM by jsonesen
comment:5 Changed on 04/11/2017 at 10:22:04 AM by kvas
Sounds good. So this can be closed then, right?
comment:6 Changed on 04/11/2017 at 11:11:20 AM by jsonesen
- Resolution set to fixed
- Status changed from reviewing to closed
This actually was addressed in the commit which added the logging to the formmail script. I just realized that I never updated this ticket. Apologies.