Opened on 03/17/2017 at 01:33:10 PM
Closed on 03/20/2017 at 11:54:45 AM
#5012 closed change (fixed)
Support "minimum_opera_version" in Chrome/Opera packager
| Reported by: | sebastian | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | jsonesen, kvas | Blocked By: | |
| Blocking: | #4787 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Currently, Adblock Plus can be installed on outdated Opera versions where it won't work. This will raise the impression that its Adblock Plus' fault being broken, when the user rather has to update their browser.
On Chrome, on the other hand, you cannot install Adblock Plus if it requires a newer Chrome version, neither do you get updates, like it should. This mechanism is enabled by the minimum_chrome_version field in the generated mainfest.json, which is populated with the value of compat.chrome from metadata.chrome. Opera supports the same mechanism, but the field is called minimum_opera_version and must refer to the respective Opera version instead, which however isn't supported by buildtools.
What to change
If compat.opera is configured in the metadata.* file ...
[compat] opera = 36.0
... the generated manifest.json file should include the minimum_opera_version key and the respective value (just like compat.chrome/minimum_chrome_version is already implemented).
{
...
"minimum_opera_version": "36.0",
...
}
Attachments (0)
Change History (7)
comment:1 Changed on 03/17/2017 at 02:52:02 PM by mapx
- Summary changed from Support "mimimum_opera_version" in Chrome/Opera packager to Support "minimum_opera_version" in Chrome/Opera packager
comment:2 Changed on 03/18/2017 at 04:24:50 PM by jsonesen
comment:3 Changed on 03/20/2017 at 08:44:49 AM by jsonesen
- Owner set to jsonesen
comment:5 Changed on 03/20/2017 at 09:11:25 AM by jsonesen
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 03/20/2017 at 11:44:24 AM by abpbot
A commit referencing this issue has landed:
Issue 5012 - Add minimum_opera_version support to metadata.json
comment:7 Changed on 03/20/2017 at 11:54:45 AM by jsonesen
- Resolution set to fixed
- Status changed from reviewing to closed
To do this, wont I just update the template?