Opened on 03/30/2017 at 05:34:01 AM
Closed on 03/30/2017 at 07:17:46 PM
#5058 closed change (fixed)
Fix code style in Utils class
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P5 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
For some reason https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java class readAssetAsString() method has same-line braces and it does not respect our coding style.
What to change
Check our code style rules are respected including braces.
Attachments (0)
Change History (4)
comment:1 Changed on 03/30/2017 at 05:39:41 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/30/2017 at 05:45:01 AM by asmirnov
comment:3 Changed on 03/30/2017 at 07:15:28 PM by abpbot
A commit referencing this issue has landed:
Issue 5058 - Fix code style in Utils class
comment:4 Changed on 03/30/2017 at 07:17:46 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Yes, it was approved https://codereview.adblockplus.org/29361445/diff/29369147/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java.
It makes automatic code style check (#4248) even important.