Opened on 03/30/2017 at 04:00:34 PM
Last modified on 10/08/2019 at 05:51:54 PM
#5066 new change
Don't download subscription when connection parameters are inappropriate
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | fhd, vickyyu, erikvold | Blocked By: | |
Blocking: | #5182 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by fhd)
Background
Some libadblockplus users are asking about the functionality reducing the traffic usage for example when connection is metered or not Wi-Fi. Working with one of the users it had been decided to have an option to don't update subscriptions in certain circumstances.
High-level overview
Because of complexity and uniqueness on each platform of network system, its available API and application UI it's better to place the most part of details to platform specific projects which can provide the core with an asynchronous function "returning" Boolean indicating whether the current connection is suitable for downloading of a subscription.
Additional notes
- there should be an API reflecting the reason subscription has not been updated for better UX, e.g. a distinguishable error code, not merely unknown error.
- the API should support manual forcing of subscription update disregarding the circumstances
- just in case, it should not concern all network requests, other requests, e.g. to notification.json should continue to work.
Please file corresponding issue for core.
Attachments (0)
Change History (17)
comment:1 Changed on 04/04/2017 at 03:42:38 PM by fhd
- Component changed from Unknown to Libadblockplus
- Description modified (diff)
- Keywords meta removed
- Priority changed from Unknown to P2
- Ready set
- Summary changed from [meta] Don't download subscription when connection parameters are inappropriate to Don't download subscription when connection parameters are inappropriate
comment:2 Changed on 04/25/2017 at 10:35:55 AM by sergz
- Blocking 5182 added
comment:3 Changed on 12/21/2017 at 11:30:52 AM by fhd
- Cc trev removed
comment:4 Changed on 11/15/2018 at 03:20:34 AM by erikvold
- Cc erikvold added
comment:5 Changed on 04/19/2019 at 06:11:02 AM by JohnKent
comment:6 Changed on 05/20/2019 at 09:12:59 AM by MorganAlice
spam
comment:7 Changed on 05/30/2019 at 10:56:45 AM by annajohnsn
spam
comment:8 Changed on 06/14/2019 at 06:31:12 AM by casparlee
spam
comment:9 Changed on 06/16/2019 at 06:31:15 PM by milanjoy
spam
comment:10 Changed on 06/17/2019 at 12:38:48 PM by milanjoy
spam
comment:11 Changed on 07/17/2019 at 07:10:26 PM by hayat56
spam
comment:12 Changed on 07/31/2019 at 11:23:44 AM by zerathomaz
spam
comment:13 Changed on 08/09/2019 at 03:37:11 AM by David090
spam
comment:14 Changed on 08/22/2019 at 12:02:19 PM by ManuelR
spam
comment:15 Changed on 08/29/2019 at 06:14:25 AM by finestediting
spam
comment:16 Changed on 09/03/2019 at 07:33:41 AM by JessicaJones121
spam
comment:17 Changed on 09/25/2019 at 11:11:08 AM by Lcx666iixx
spam
spam