Opened on 03/31/2017 at 05:59:53 AM
Closed on 04/03/2017 at 11:18:41 AM
Last modified on 06/28/2017 at 09:41:20 AM
#5077 closed change (fixed)
Update buildtools dependency to 1ed9c0c32f78
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.13.3-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | #5060, #5078 |
| Blocking: | #5080 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Once the improvements (#5060, #5078) to our module packaging system in buildtools changes have landed we'll need to update the buildtools dependency in adblockpluschrome.
Our changes will be included:
This update pulls in one more change, which however, has no effect on the Chrome builds whatsoever:
What to change
- Update the buildtools dependency to 1ed9c0c32f78.
- Remove lib/info.js from metadata.common.
- Remove the "Module framework stuff" section from lib/compat.js.
- Add the new injectinfomodule option for files in the convert_js section which want to use the info module
Hints for testers
- Ensure both the WebExtension and Chrome extension seem to work properly. Check for exceptions in the developer console (background console for Chrome). If something has gone wrong it should be very obvious!
Attachments (0)
Change History (13)
comment:1 Changed on 03/31/2017 at 06:03:29 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/31/2017 at 06:36:01 AM by kzar
- Blocked By 5078 added
comment:3 Changed on 03/31/2017 at 08:57:03 AM by kzar
- Blocking 5080 added
comment:4 Changed on 03/31/2017 at 09:01:50 AM by kzar
- Blocking 4864 removed
comment:5 Changed on 04/01/2017 at 03:46:44 PM by sebastian
- Blocking 5084 added
comment:6 Changed on 04/02/2017 at 05:28:41 AM by kzar
- Description modified (diff)
- Summary changed from Update buildtools dependency to 5060-modules to Update buildtools dependency to 5078-modules
comment:7 Changed on 04/03/2017 at 06:04:29 AM by sebastian
- Blocking 5084 removed
comment:9 Changed on 04/03/2017 at 07:31:20 AM by kzar
- Description modified (diff)
- Summary changed from Update buildtools dependency to 5078-modules to Update buildtools dependency to 1ed9c0c32f78
comment:10 Changed on 04/03/2017 at 10:09:48 AM by sebastian
- Description modified (diff)
comment:11 Changed on 04/03/2017 at 11:17:44 AM by abpbot
comment:12 Changed on 04/03/2017 at 11:18:41 AM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 06/28/2017 at 09:41:20 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
The extension generally looks okay and no obvious errors occur (such as in the background console).
ABP 1.13.2.1785
Firefox Dev 55.0b5 / Windows 7
Chrome 49 / 59 / Windows 7
Opera 39 / 45 / Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5077 - Update buildtools dependency to 1ed9c0c32f78