Opened on 03/31/2017 at 06:36:01 AM
Closed on 04/03/2017 at 07:30:47 AM
#5078 closed change (rejected)
Allow convert_js to combine files which have already been processed
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | #5077 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
For #4864 we want to start using proper modules for the content scripts. To do that we need to use convert_js on some of them, one being elemHideEmulation.js. Since elemHideEmulation.js is itself a combination of some other files we need to be able to combine files which have already been processed / combined.
What to change
Tweak the convertJS logic in packagerChrome.py so that input files already in the files dictionary are not read again.
Attachments (0)
Change History (3)
comment:1 Changed on 03/31/2017 at 06:38:03 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 in reply to: ↑ description Changed on 04/03/2017 at 06:01:08 AM by sebastian
- Ready unset
comment:3 Changed on 04/03/2017 at 07:30:47 AM by kzar
- Resolution set to rejected
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
We should include lib/common.js and chrome/content/elemHideEmulation.js from adblockpluscore as separate modules. So instead of changing buildtools here, we should just add const {filterToRegExp} = require('common'); to elemHideEmulation.js in adblockpluscore.