Opened on 04/03/2017 at 10:53:35 AM

Closed on 04/09/2017 at 04:39:54 AM

Last modified on 07/07/2017 at 01:35:24 PM

#5092 closed change (fixed)

Update adblockplusui dependency to 5503e0f10d7b

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.3-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, Ross Blocked By: #5091
Blocking: #4455 Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29401590/

Description (last modified by kzar)

Background

Once adblockplusui supports the webrtc request type we'll need to update the dependency in adblockpluschrome.

What to change

Update the adblockplusui dependency to 5503e0f10d7b. No other changes will be included.

Hints for testers

Check that our devtools pane allows "WEBRTC" request types to be filtered with the drop down menu.

Attachments (0)

Change History (7)

comment:1 Changed on 04/03/2017 at 10:53:51 AM by kzar

  • Blocked By 5091 added
  • Blocking 4455 added

comment:2 Changed on 04/07/2017 at 01:16:57 PM by kzar

  • Description modified (diff)
  • Ready set
  • Summary changed from Update adblockplusui dependency to 5091-webrtc to Update adblockplusui dependency to 5503e0f10d7b

comment:3 Changed on 04/08/2017 at 07:51:06 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/08/2017 at 07:51:52 AM by kzar

  • Description modified (diff)

comment:5 Changed on 04/09/2017 at 04:39:54 AM by kzar

  • Cc Ross added
  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 04/09/2017 at 04:40:41 AM by kzar

A commit referencing this issue has landed:
Issue 4455, 5087, 5092 - Wrap RTCPeerConnection to allow blocking

comment:7 Changed on 07/07/2017 at 01:35:24 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. WebRTC requests can be filtered in the DevTools panel.

ABP 1.13.2.1785
Chrome 49 / 59 / Windows 7
Opera 36 / 45 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.