Opened on 04/03/2017 at 01:05:00 PM
Closed on 04/09/2018 at 10:51:19 AM
#5093 closed change (rejected)
Indicate whether request in devtools panel belongs to tab
| Reported by: | greiner | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian | Blocked By: | #6402 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
Starting with #5042 the devtools panel will receive requests that were made from tabs without an ID. To avoid confusion we should visually differentiate those from requests originating from the tab that the devtools window is associated with.
What to change
Use different styles for requests from tabs without an ID in the devtools panel (see design proposal). Furthermore, we may want to provide information on how they are different and how they differ from regular requests but grouping them under "Requests from background tabs" should be sufficient for now.
Attachments (1)
Change History (12)
comment:1 Changed on 04/03/2017 at 01:32:10 PM by sebastian
- Cc sebastian added
Changed on 04/10/2017 at 12:55:37 PM by greiner
comment:2 Changed on 04/10/2017 at 12:58:50 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 02/12/2018 at 12:55:08 PM by agiammarchi
- Owner set to agiammarchi
comment:5 Changed on 03/02/2018 at 10:20:49 AM by agiammarchi
- Blocked By 6402 added
comment:6 Changed on 04/05/2018 at 04:49:00 PM by greiner
comment:7 Changed on 04/05/2018 at 06:22:35 PM by sebastian
comment:8 Changed on 04/06/2018 at 08:08:47 AM by agiammarchi
so if I understand correctly we don't care about informing older versions of the browser and I can abandon the codereview, right?
comment:9 follow-up: ↓ 10 Changed on 04/06/2018 at 11:40:02 AM by greiner
@Sebastian Does that mean that the DevTools panel won't receive any requests anymore that don't belong to the tab it inspects? Because from the ticket description this wasn't clear. If so, this ticket could be closed.
However, as Andrea pointed out, we may still want to add it to support older browser versions. What's your take on that?
comment:10 in reply to: ↑ 9 Changed on 04/06/2018 at 08:23:29 PM by sebastian
With #6543, requests from Service/Shared Workers are associated with the document that caused the worker to spawn (on all versions of Firefox and Chromium >=63), and will only be logged to the devtools panel on pages controlled by that worker, with the respective origin indicated.
With #6544, we will ignore requests sent by the browser and the extension itself, which leaves no orphaned requests left on Firefox and Chromium >=63. However, as a side effect we will also stop processing requests that have been sent by Service/Shared Workers on Chromium <63 and Microsoft Edge, since those cannot be distinguished from requests sent by the browser or the extension itself.
comment:11 Changed on 04/09/2018 at 10:51:19 AM by agiammarchi
- Resolution set to rejected
- Status changed from new to closed
Note that according to #6543, we'll be able to associate all requests with a domain starting with Chrome 63.