Opened on 04/04/2017 at 12:44:19 PM
Closed on 04/05/2017 at 07:10:02 AM
Last modified on 04/05/2017 at 12:22:47 PM
#5099 closed defect (fixed)
Element Hiding Helper: Console errors when using view source in window
| Reported by: | Ross | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.4 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 2.8.2
EHH 1.3.10.551-beta
Firefox 52 / Windows 7
(Also occurs when using ABP 2.8.2.4242-beta)
How to reproduce
- Start EHH element selection.
- Hover an element (any).
- Press U to view source of element hovered in a window.
Observed behaviour
The source is displayed in a new window as expected but the following errors also occur:
TypeError: state.selectedElement is undefined commands.js:50:5
Error: Must supply a URL when when opening view source ViewSourceBrowser.jsm:185:13
Expected behaviour
Errors not to occur.
Attachments (0)
Change History (7)
comment:1 Changed on 04/04/2017 at 06:00:56 PM by trev
- Owner set to trev
comment:2 Changed on 04/04/2017 at 06:01:16 PM by trev
- Priority changed from P3 to P1
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/05/2017 at 07:09:01 AM by abpbot
comment:4 Changed on 04/05/2017 at 07:10:02 AM by trev
- Milestone set to Element-Hiding-Helper-1.4
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/05/2017 at 12:14:15 PM by Ross
The TypeError is fixed but the error about supplying a URL still occurs. Is it ignorable? Everything seems to function as expected.
ABP 2.8.2
EHH 1.3.10.522-beta
Firefox 52 / Windows 7
comment:6 Changed on 04/05/2017 at 12:20:20 PM by trev
Yes, that isn't our code. As long as the window actually opens the error should be fine.
comment:7 Changed on 04/05/2017 at 12:22:47 PM by Ross
- Verified working set
Fixed.
ABP 2.8.2
EHH 1.3.10.522-beta
Firefox 52 / Windows 7
A commit referencing this issue has landed:
Issue 5097, issue 5099 - Only retrieve element source from the process actually selecting