Opened on 04/04/2017 at 12:43:41 PM

Closed on 04/05/2017 at 12:19:11 PM

#5098 closed change (fixed)

Expose FilterStorage initialization state

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29402582/

Description

Background

Adblock Plus for Firefox was previously relying on FilterStorage._loading to recognize an uninitialized filter storage. Now that this flag is gone it will occasionally start first-run actions too early.

What to change

Expose FilterStorage.initialized that is set after the first FilterStorage.loadFromDisk() call completes.

Attachments (0)

Change History (3)

comment:1 Changed on 04/04/2017 at 12:51:47 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/05/2017 at 12:15:13 PM by abpbot

A commit referencing this issue has landed:
​Issue 5098 - Expose FilterStorage initialization state

comment:3 Changed on 04/05/2017 at 12:19:11 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.