Opened on 04/05/2017 at 03:56:31 PM
Closed on 04/06/2017 at 06:24:34 AM
Last modified on 05/24/2017 at 11:52:39 AM
#5110 closed change (fixed)
Update adblockpluscore dependency to revision 387cff1ab5e0
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.9-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Background
The changes in #5052 caused a regression, first-run actions running prematurely on update. We need #5098 in order to address this.
What to change
Update dependency and make sure !FilterStorage.initialized is used instead of FilterStorage._loading.
What to test
First-run page should not open on update and filter storage shouldn't be reinitialized (default subscription added) - unless there is really no data (adblockplus/patterns.ini removed and no backups). Note that this is really about the update scenario, you have to be updating from a previous development build.
First-run page should open as usual on initial installation and default subscriptions should be added.
Attachments (0)
Change History (4)
comment:1 Changed on 04/05/2017 at 04:08:31 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/06/2017 at 06:23:39 AM by abpbot
comment:3 Changed on 04/06/2017 at 06:24:34 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/24/2017 at 11:52:39 AM by Ross
- Verified working set
Fixed. FRP does not appear and subscriptions/filters are not changed on update. Unless, there is no data, where they do appear/change (as described).
ABP 2.8.2.4246-beta
Firefox 51 / 53 / Dev (54) / Windows 7
A commit referencing this issue has landed:
Issue 5110 - Update adblockpluscore dependency to revision 387cff1ab5e0, fixing first-run page showing up on update