Opened on 04/07/2017 at 05:24:50 AM

Closed on 05/05/2017 at 11:44:54 AM

#5121 closed change (fixed)

Use Acceptable Ads API in libadblockplus

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz, fhd Blocked By: #4657
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29405564/

Description

Background

AA API in libadblockplus was added in #4657. Since we're having the same methods set in libadblockplus-android we should avoid using it and use existing libadblockplus API.

What to change

Use AA API from libadblockplus, avoid changing API if possible for back-compatibility reason.

Attachments (0)

Change History (6)

comment:1 Changed on 04/07/2017 at 05:25:50 AM by asmirnov

Recompilation of libadblockplus-binaries is required

comment:2 Changed on 04/07/2017 at 05:27:13 AM by asmirnov

  • Summary changed from Use AA API in libadblockplus to Use Acceptable Ads API in libadblockplus

comment:3 Changed on 04/07/2017 at 07:05:27 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/07/2017 at 08:15:14 AM by asmirnov

  • Ready set

comment:5 Changed on 05/05/2017 at 11:44:20 AM by abpbot

A commit referencing this issue has landed:
​Issue 5121 - Use Acceptable Ads API in libadblockplus

comment:6 Changed on 05/05/2017 at 11:44:54 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.