Opened on 04/07/2017 at 08:25:08 AM
Closed on 09/13/2017 at 11:52:48 PM
Last modified on 09/15/2017 at 12:19:08 AM
#5122 closed change (fixed)
[UI] Redesign Settings Menu
| Reported by: | mario | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-2.0.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4706 | Platform: | Adblock Browser for iOS |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
This issue is part of ABB's redesign as described under #4706.
What to change
Apply the new design/functionality to ABB's settings menu as outlined in these specifications.
Existing features, not covered in this document, stay intact.
Two features currently present in ABB 1.5.3 aren't covered by the specifications above yet:
- Keep the GENERAL settings group with its two items Crash and Error Reports and Devbuild Settings
- Keep the Crash and "Error Reports" settings view and adjust it to match the new design as shown in this screenshot
- Keep the "Devbuild Settings" settings view and adjust it to match the new design as shown in this screenshot
Links
Within the specs there is one external link. Please point it to the following resource:
- "Choose whether to include nonintrusive, non-animated ads that adhere to strict criteria. Learn more."
Learn more links to https://acceptableads.com/users.
Discrepancies
Within the specs there is one external link which needs to be removed. Please remove the following link:
- "You have turned off ad blocking on these websites and will see ads on them. Learn more."
Remove Learn more.
Attachments
Attachments (3)
Change History (20)
Changed on 04/07/2017 at 10:21:18 AM by mario
comment:2 Changed on 04/07/2017 at 12:08:42 PM by mario
comment:3 Changed on 07/26/2017 at 10:38:48 AM by mario
- Description modified (diff)
As pointed out, the current specifications lack crash report settings as well as devbuild settings as currently available in ABB 1.5.3.
We're working on adding them to the specs as well. Until then I've added mockups to the issue.
Changed on 07/26/2017 at 10:39:10 AM by mario
Changed on 07/26/2017 at 10:39:18 AM by mario
comment:5 Changed on 08/07/2017 at 02:54:54 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 08/08/2017 at 04:22:39 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:10 Changed on 09/12/2017 at 09:36:23 AM by mario
- Description modified (diff)
comment:11 Changed on 09/12/2017 at 09:43:14 AM by mario
- Resolution fixed deleted
- Status changed from closed to reopened
Updated the description with the missing link and a minor change to remove the second link.
comment:12 Changed on 09/12/2017 at 09:43:55 AM by mario
- Ready set
comment:13 Changed on 09/12/2017 at 10:00:44 AM by mario
- Description modified (diff)
comment:14 Changed on 09/13/2017 at 02:27:11 PM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:15 Changed on 09/13/2017 at 11:50:16 PM by traynard
- Resolution fixed deleted
- Status changed from closed to reopened
According to Specifications doc, "Language" should be shown as one of the primary options beneath "Clear browsing data". However, it is actually placed withing "Ad blocking" under the "More Options" section.
comment:16 Changed on 09/13/2017 at 11:52:48 PM by traynard
- Resolution set to fixed
- Status changed from reopened to closed
comment:17 Changed on 09/15/2017 at 12:19:08 AM by traynard
- Verified working set
Updated the specifications and removed two features from the scope of this issue, as we're not ready yet to implement them:
I will file those two changes within follow-up issues not in relation to the redesign.