Opened on 04/12/2017 at 03:44:26 PM

Closed on 07/07/2017 at 08:30:38 AM

Last modified on 10/08/2019 at 05:52:17 PM

#5135 closed change (fixed)

Reduce font size and padding on smaller screens on acceptableads.com

Reported by: juliandoucette Assignee: ire
Priority: P2 Milestone: acceptableads.com/committee cleanup
Module: Websites Keywords: goodfirstbug
Cc: saroyanm, jeen, erick Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29438582

Description (last modified by juliandoucette)

Background

See https://issues.adblockplus.org/ticket/5105#comment:7

What to change

  • Reduce font size and padding around content on small screens.
    • Exact sizes to-be-defined in codereview.

Attachments (0)

Change History (10)

comment:1 Changed on 04/12/2017 at 03:45:14 PM by juliandoucette

  • Priority changed from P3 to P5

Jeen should we wait for you to provide some guidance about the exact size and padding or should we wing it and ask for your approval?

comment:2 Changed on 04/13/2017 at 11:29:14 AM by jeen

  • I would say for the header - bring it down by about 40% - but feel free to use your judgement. (Right now it is 42px, so perhaps down to 32px)
  • For the body text, don't go below 16px.

comment:3 Changed on 04/24/2017 at 04:11:47 PM by juliandoucette

  • Description modified (diff)
  • Priority changed from P5 to P2
  • Ready set

I set P2 because:

  • This issue is pretty bad on small screens
  • This website often trends when AA and AAC get media attention

comment:4 Changed on 05/16/2017 at 04:23:00 AM by ire

  • Owner set to iaderinokun

comment:5 Changed on 05/16/2017 at 04:30:30 AM by ire

  • Status changed from new to reviewing

Code Review - ​https://codereview.adblockplus.org/29438582

comment:6 follow-up: Changed on 05/16/2017 at 03:54:59 PM by juliandoucette

  • Review URL(s) modified (diff)

Put review url into "Review URL(s)".

comment:7 in reply to: ↑ 6 Changed on 05/16/2017 at 06:28:22 PM by ire

Replying to juliandoucette:

Put review url into "Review URL(s)".

Okay.

comment:8 Changed on 07/07/2017 at 08:28:48 AM by abpbot

A commit referencing this issue has landed:
​Issue 5135 - Reduce font size and padding on smaller screens on acceptableads.com

comment:9 Changed on 07/07/2017 at 08:30:38 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 06/21/2019 at 05:57:33 AM by modifaku

spam

Last edited on 10/08/2019 at 05:52:17 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.