Opened on 04/17/2017 at 07:07:32 AM

Closed on 04/28/2017 at 10:19:39 AM

#5148 closed change (fixed)

Remove Apache String Utils code

Reported by: asmirnov Assignee:
Priority: P4 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29415555/

Description (last modified by asmirnov)

Background

For back-compatibility reason we're still having Apache String Utils classes right in libadblockplus-android code. Since we don't support proxy app any more and it's preferred not to introduce conflicts in the 3rd-party apps that are using both libadblockplus-android and Apache String Utils i'd suggest to remove it from our code.

Previously #4260 was requested and approved but skipped eventually.

What to change

Remove org.apache.commons.lang package and some related/unused string utils code.

Attachments (0)

Change History (4)

comment:1 Changed on 04/17/2017 at 07:10:15 AM by asmirnov

  • Description modified (diff)

comment:2 Changed on 04/17/2017 at 07:13:00 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/28/2017 at 10:18:36 AM by abpbot

A commit referencing this issue has landed:
​Issue 5148 - Remove Apache String Utils code

comment:4 Changed on 04/28/2017 at 10:19:39 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.