Opened on 04/20/2017 at 10:42:07 AM
Closed on 11/21/2017 at 09:31:25 PM
#5159 closed change (fixed)
[emscripten] Expose BlockingFilter.collapse property
| Reported by: | trev | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #4125 we implemented parsing for $~collapse option but didn't expose it. Given that we no longer support a global off-switch for collapsing, $collapse is the default behavior and can be ignored.
What to change
Turn RegExpFilter.mCollapse into a boolean defaulting to true and expose it on BlockingFilter.
Attachments (0)
Change History (4)
comment:1 Changed on 10/12/2017 at 04:08:54 PM by hfiguiere
- Owner set to hfiguiere
comment:2 Changed on 10/12/2017 at 06:42:21 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/21/2017 at 09:30:34 PM by abpbot
comment:4 Changed on 11/21/2017 at 09:31:25 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5159 - Expose collapse property for BlockingFilter