Opened on 04/20/2017 at 12:50:16 PM
Closed on 10/13/2017 at 12:35:51 PM
#5160 closed change (fixed)
[emscripten] Expose changed class and property names to JavaScript
| Reported by: | trev | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #4127 we renamed SpecialSubscription into UserDefinedSubscription. Also, some DownloadableSubscription properties were renamed: expires into hardExpiration, errors into errorCount, version into dataRevision. These changes are limited to the C++ code so far, JS bindings expose the old names.
What to change
Expose the new names via JS bindings. Change lib/subscriptionClasses.js to establish the old names as aliases for the new names. This aliasing should be removed eventually.
Attachments (0)
Change History (4)
comment:1 Changed on 10/11/2017 at 07:21:37 PM by hfiguiere
- Owner set to hfiguiere
comment:2 Changed on 10/11/2017 at 07:38:58 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/13/2017 at 12:34:22 PM by abpbot
comment:4 Changed on 10/13/2017 at 12:35:51 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5160 - Alias new class names and properties.