Opened on 04/20/2017 at 02:11:11 PM

Closed on 04/21/2017 at 01:01:36 PM

#5162 closed change (fixed)

Pass a JsEngine& to JsContext

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29418664

Description (last modified by sergz)

Background

Pass a const JsEngine& to JsContext instead a JsEnginePtr.

What to change

Change JsContext.h and .cpp to receive a const JsEngine&.

Attachments (0)

Change History (5)

comment:1 Changed on 04/20/2017 at 02:15:36 PM by sergz

  • Description modified (diff)
  • Priority changed from Unknown to P4

comment:2 Changed on 04/20/2017 at 02:26:39 PM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 04/20/2017 at 07:54:33 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/21/2017 at 01:00:42 PM by abpbot

A commit referencing this issue has landed:
​Issue 5162 - JsContext() takes a JsEngine&

comment:5 Changed on 04/21/2017 at 01:01:36 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.