Opened on 04/20/2017 at 03:01:21 PM
Closed on 04/21/2017 at 02:22:25 PM
#5163 closed change (fixed)
Reduce the use of FilterPtr
Reported by: | hfiguiere | Assignee: | hfiguiere |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | sergz | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
Reduce the use of FilterPtr
What to change
- Change FilterPtr to be a unique_ptr<>
- Pass a Filter& whenever it is appropriate (mostly everywhere but FilterEngine::Matches related methods).
Attachments (0)
Change History (4)
comment:1 Changed on 04/20/2017 at 03:47:10 PM by hfiguiere
- Owner set to hfiguiere
comment:2 Changed on 04/21/2017 at 01:05:13 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/21/2017 at 02:20:51 PM by abpbot
comment:4 Changed on 04/21/2017 at 02:22:25 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5163 - Reduce the use of FilterPtr