Opened on 04/20/2017 at 03:32:02 PM

Closed on 04/25/2017 at 12:19:53 PM

#5165 closed change (fixed)

Remove SubscriptionPtr

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29419623

Description

Background

Remove SubscriptionPtr. Replace with a Subscription&

What to change

  • Pass Subscription& whenever it is enough
  • Remove SubscriptionPtr

Attachments (0)

Change History (5)

comment:1 Changed on 04/20/2017 at 03:32:16 PM by hfiguiere

  • Cc sergz added

comment:2 Changed on 04/21/2017 at 12:32:55 PM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 04/21/2017 at 02:09:08 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/25/2017 at 11:58:56 AM by abpbot

A commit referencing this issue has landed:
​Issue 5165 - Remove SubscriptionPtr

comment:5 Changed on 04/25/2017 at 12:19:53 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.