Opened on 04/20/2017 at 03:03:54 PM

Closed on 04/25/2017 at 12:20:11 PM

#5164 closed change (fixed)

Remove NotificationPtr

Reported by: hfiguiere Assignee: hfiguiere
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29419629

Description

Background

Remove NotificationPtr and use plain Notification object

What to change

  • Get rid of NotificationPtr.
  • Pass Notification& whenever it is applicable

Attachments (0)

Change History (4)

comment:1 Changed on 04/21/2017 at 12:33:28 PM by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed on 04/21/2017 at 02:09:25 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/25/2017 at 11:57:27 AM by abpbot

A commit referencing this issue has landed:
​Issue 5164 - Remove NotificationPtr

comment:4 Changed on 04/25/2017 at 12:20:11 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.