Opened on 04/27/2017 at 05:19:20 PM
Closed on 05/10/2017 at 10:10:41 AM
Last modified on 05/10/2017 at 12:09:23 PM
#5193 closed change (fixed)
Apply Samsung Internet UI changes to the first run slide
| Reported by: | mario | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.0 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | diegocarloslima | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Background
Since Samsung Internet 5.0, the method of enabling ad blocking has changed. As a result, we need to apply changes to the first run slide to reflect the aforementioned method.
Please note, that ABP for Samsung Internet stays available for 4.0 users and thus needs to display different versions of the first run slide depending on the version of Samsung Internet the user has.
What to change
UI
Display the following text on the first run screen if Samsung Internet 4.0 is installed:
You’re in control Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the <b>Allow some nonintrusive ads</b> option. Enable Adblock Plus in Samsung Internet 4.0 or above 1. Open Samsung Internet. 2. Tap <b>More</b> and select <b>Settings</b>. 3. Tap <b>Advanced</b>. 4. Tap <b>Block content</b>. 5. Activate the <b>Block content</b> functionality. 6. Select Adblock Plus for Samsung Internet. Configure Samsung Internet
Styling as well as links stay intact. Text marked with <b> tags are supposed to be displayed in a bold font.
Display the following text on the first run screen if Samsung Internet 5.0 is installed:
You’re in control Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the <b>Allow some nonintrusive ads</b> option. Enable Adblock Plus in Samsung Internet 4.0 or above 1. Open Samsung Internet. 2. Tap <b>⋮</b> and select <b>Extensions</b>. 3. Tap <b>Content blockers</b>. 4. Select Adblock Plus for Samsung Internet. Configure Samsung Internet
Styling as well as links stay intact. Text marked with <b> tags are supposed to be displayed in a bold font.
Logic
If Configure Samsung Internet is tapped, open Samsung Internet and display the "Content blockers" settings pane.
Attachments (0)
Change History (13)
comment:3 Changed on 05/03/2017 at 07:10:34 PM by diegocarloslima
- Description modified (diff)
- Summary changed from Apply SBrowser's UI changes to the first run slide to Apply Samsung Internet UI changes to the first run slide
comment:4 Changed on 05/04/2017 at 01:14:48 PM by scheer
comment:6 Changed on 05/08/2017 at 08:18:32 PM by diegocarloslima
- Cc diegocarloslima added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 05/09/2017 at 08:43:44 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The following, correct UI text is displayed on the first screen when Samsung Internet 4.0 is installed:
You’re in control Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the <b>Allow some nonintrusive ads</b> option. Enable Adblock Plus in Samsung Internet 4.0 or above 1. Open Samsung Internet. 2. Tap <b>More</b> and select <b>Settings</b>. 3. Tap <b>Advanced</b>. 4. Tap <b>Block content</b>. 5. Activate the <b>Block content</b> functionality. 6. Select Adblock Plus for Samsung Internet. Configure Samsung Internet
- The following, correct UI text is displayed on the first screen when Samsung Internet 5.0 is installed:
You’re in control Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the <b>Allow some nonintrusive ads</b> option. Enable Adblock Plus in Samsung Internet 4.0 or above 1. Open Samsung Internet. 2. Tap <b>⋮</b> and select <b>Extensions</b>. 3. Tap <b>Content blockers</b>. 4. Select Adblock Plus for Samsung Internet. Configure Samsung Internet
- 'When Configure Samsung Internet' is tapped, Samsung Internet is opened and displays the "Content blockers" settings pane.
adblockplussbrowser-release-signed-1
Galaxy S4
Android 5.0.1
Samsung Internet 4.0.10-53
adblockplussbrowser-release-signed-1
Galaxy S7
Android 7.0
Samsung Internet 5.0.30-40
comment:8 Changed on 05/09/2017 at 01:47:55 PM by jwangenheim
- Blocking 5215 added
comment:9 Changed on 05/10/2017 at 08:32:55 AM by jwangenheim
- Owner set to jwangenheim
comment:10 Changed on 05/10/2017 at 08:35:32 AM by abpbot
A commit referencing this issue has landed:
Issue 5193 - Apply Samsung Internet UI changes to the first run slide
comment:11 Changed on 05/10/2017 at 10:08:32 AM by abpbot
A commit referencing this issue has landed:
Issue 5193 - Apply Samsung Internet UI changes to the first run slide
comment:12 Changed on 05/10/2017 at 10:10:41 AM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 05/10/2017 at 12:09:23 PM by jwangenheim
- Blocking 5215 removed
What is actually shown is:
The main difference here is the use of the word 'configuring', instead of 'tapping'.