Opened on 04/28/2017 at 07:22:47 AM
Closed on 07/05/2017 at 08:32:23 AM
#5194 closed change (fixed)
Remove Tracking Protection from Private Browsing
| Reported by: | mario | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | fhd | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29430589/ |
||
Description (last modified by mario)
Background
Fennec's tracking protection in private browsing conflicts with ABP. Thus we want to remove this feature altogether.
What to change
Disable Fennec's tracking protection "privacy.trackingprotection.enabled" by default and remove the possibility to turn it on in the settings pane.
If not deactivated by turning off "privacy.trackingprotection.enabled" remove its corresponding functionality/UI (the following issues link to Bugzilla. Their content will not be duplicated/rephrased here):
- Tracking protection in private browsing meta issue
- Tracking protection in site identity popup as shown here and here
- Doorhanger icon and Doorhanger visuals as shown here
- Tracking protection settings option as shown here
- Tracking protection first run slide in private browsing as shown here
- Telemetry probes
- Tracking protection contextual hint as shown here
- Tracking protection headline & text in private browsing empty tabs as shown here
Attachments (2)
Change History (21)
comment:4 Changed on 05/15/2017 at 02:16:52 PM by fhd
- Owner set to diegocarloslima
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 05/15/2017 at 02:17:02 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 05/15/2017 at 02:17:23 PM by fhd
- Cc fhd added
comment:7 Changed on 06/01/2017 at 09:47:28 PM by abpbot
A commit referencing this issue has landed:
Issue 5194 - Remove Tracking Protection from Private Browsing
comment:8 Changed on 06/01/2017 at 09:47:45 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 06/08/2017 at 01:41:53 PM by mario
- Resolution fixed deleted
- Status changed from closed to reopened
Reopened as tracking protection is still advertised prominently in empty private mode tabs as shown here. Please remove this message as per the issues description.
comment:10 Changed on 06/08/2017 at 07:44:48 PM by diegocarloslima
- Review URL(s) modified (diff)
Changed on 06/08/2017 at 08:43:17 PM by diegocarloslima
Changed on 06/08/2017 at 08:43:29 PM by diegocarloslima
comment:11 Changed on 06/08/2017 at 08:45:44 PM by diegocarloslima
Added screenshots that illustrate the string changes in private browsing tab
comment:12 Changed on 06/12/2017 at 02:30:40 PM by abpbot
A commit referencing this issue has landed:
Issue 5194 - Remove Tracking Protection from Private Browsing
comment:13 Changed on 06/12/2017 at 02:32:44 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reopened to closed
comment:14 Changed on 06/20/2017 at 01:23:35 PM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
- The Tracking Protection settings option is now removed.
- The Tracking Protection first run slide in private browsing is now removed.
- The Tracking Protection contextual hint is now removed.
- The Tracking Protection in site identity popup is now correctly changed.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
- 'Tracking Protection headline & text in private browsing empty tabs' The private browsing tab - after.jpeg shows a link to 'Want to learn more?', this is not part of the new tab screen, even though the rest of the text has been edited correctly.
- 'Doorhanger icon' When viewing Google maps, the 'Share Location' icon is briefly shown and then removed within Private Tabs, from my understanding this pop-up should not be shown at all?
comment:15 Changed on 06/21/2017 at 08:20:33 AM by scheer
- Telemetry is no longer sent.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
comment:16 Changed on 06/30/2017 at 07:53:10 PM by diegocarloslima
The 'Want to learn more?' link was removed after I added that screenshot to this ticket. So the correct behavior is without that link.
The geolocation doorhanger seems to not be really related to the tracking protection in Firefox. I've tried in Firefox 44.0.2 and 54.0.1 with both Do not track and Tracking protection enabled and it still being shown. If we feel the need to remove the geolocation doorhanger while in private mode, I would suggest to create a follow up issue for that
comment:17 Changed on 07/03/2017 at 11:34:54 AM by mario
@diegocarloslima, since both are "resolved", the issue can be closed?
I've looked into the geolocation doorhanger issue and the mentioned screenshot indeed shows two doorhangers which are unrelated to tracking protection. I'll update the example images to only show doorhangers related to tracking protection. We don't want to remove features related to gps data of course.
comment:18 Changed on 07/03/2017 at 11:39:52 AM by mario
- Description modified (diff)
Updated the screenshot visualizing the tracking protection doorhanger as well as icon, leaving out the geolocation doorhanger. The change only concerns the TP icon in the URL bar (grey shield) as well as the TP text within the doorhanger. New screenshot.
comment:19 Changed on 07/05/2017 at 08:32:23 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- LGTM.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
Removed passage about disabling "privacy.trackingprotection.enabled" in about:config in order to avoid too many changes to the upstream code. This has been handled the same way for other options.