Opened on 03/11/2014 at 04:47:05 PM
Closed on 08/29/2019 at 05:43:52 PM
#52 closed change (rejected)
Refactor filter/subscription change notifications
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P5 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | Confidential: | no | |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Currently the filter and subscription properties triggering notifications are a getter/setter combination, the setter will call FilterNotifier. This is ugly and adds an otherwise pointless dependency on FilterNotifier in filterClasses and subscriptionClasses.
What to change
The proposal is to have these properties as regular properties. When FilterNotifier starts up it should load filterClasses and subscriptionClasses and replace the properties by a getter/setter combination that will trigger notifications.
Attachments (0)
Change History (3)
comment:1 Changed on 03/11/2014 at 09:32:43 PM by trev
- Component changed from Unknown to Core
- Priority changed from Unknown to P5
comment:2 Changed on 03/13/2014 at 07:22:00 AM by trev
- Reporter changed from philll to trev
comment:3 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Note: See
TracTickets for help on using
tickets.
This issue will likely be superseded by our current typed objects/ChimeraScript work.