Opened on 03/11/2014 at 04:48:31 PM
Closed on 03/13/2014 at 03:59:01 PM
Last modified on 03/14/2014 at 11:44:55 AM
#53 closed change (fixed)
Make sure extension name is present in all locales
| Reported by: | trev | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Automation | Keywords: | chrome |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | Confidential: | no | |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by trev)
Background
We can no longer rely on the fallback for the "name" and "description" strings, Chrome Web Store requires them to be always present now. The "name" string is being copied over from Firefox localization, yet we have some Chrome locales that simply aren't present for Firefox.
What to change
The Chrome packager needs to copy the "name" and "description" string from default locale for locales where it is missing (Firefox packager already has similar functionality, applying to all strings).
Attachments (0)
Change History (9)
comment:1 Changed on 03/11/2014 at 09:31:00 PM by trev
- Component changed from Unknown to Buildtools
- Priority changed from Unknown to P1
comment:2 Changed on 03/11/2014 at 09:36:22 PM by trev
- Keywords chrome added
comment:3 Changed on 03/12/2014 at 03:27:32 PM by trev
- Reporter changed from philll to trev
comment:4 Changed on 03/13/2014 at 10:26:43 AM by sebastian
- Owner set to sebastian
- Status changed from new to assigned
comment:6 Changed on 03/13/2014 at 03:12:58 PM by sebastian
- Status changed from assigned to reviewing
comment:7 Changed on 03/13/2014 at 03:59:01 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 03/13/2014 at 11:36:41 PM by sebastian
comment:9 Changed on 03/14/2014 at 11:44:55 AM by trev
- Milestone set to Adblock-Plus-for-Chrome-next
Note: See
TracTickets for help on using
tickets.
http://codereview.adblockplus.org/5702288324689920/