Opened on 05/18/2017 at 12:37:18 PM
Closed on 11/10/2017 at 11:15:18 AM
#5256 closed defect (rejected)
Hit counters not updated for element hiding emulation filters
| Reported by: | Ross | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | no |
| Review URL(s): | |||
Description
Environment
2.8.2.4246beta
Firefox 51 / 53 / Windows 7
How to reproduce
- Add a the custom filter: adblockplus.org##[-abp-properties="/width: [0-9]px/"]
- Navigate to https://adblockplus.org
Observed behaviour
Hit counters do not appear to be updated for element hiding emulation filters (such as the CSS filter above). They hide elements and so match, but display 0 as their hit count.
Other types of filters (non -abp-property filters) appear to have their counters updated correctly.
Expected behaviour
Hit counters to be updated for element hiding emulation filters
Attachments (0)
Change History (3)
comment:1 Changed on 05/18/2017 at 12:39:00 PM by Ross
- Summary changed from Hit counters not updated for element hiding Emulation filters to Hit counters not updated for element hiding emulation filters
comment:2 Changed on 05/24/2017 at 11:57:26 AM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Note: See
TracTickets for help on using
tickets.
Confirmed: while the element hiding emulation filters are added to blockable items, hit count isn't being increased.