Opened on 05/18/2017 at 01:03:45 PM
Closed on 05/19/2017 at 06:25:34 PM
#5257 closed change (fixed)
`npm test` should run the linter
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | kzar, trev, sebastian, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
When the review says "eslint should have caught this" that means eslint didn't get run. The best way to ensure the developer does run eslint is it run eslint as part of the tests.
What to change
-Add eslint and the eyeo eslint config as a dependency in the package.json
-Run eslint as part of npm test
-Make sure the tests can run even if linter fails.
Bonus
It will also allow us to track the linter config version to the right one.
Attachments (0)
Change History (8)
comment:1 Changed on 05/18/2017 at 03:46:50 PM by hfiguiere
- Owner set to hfiguiere
comment:2 Changed on 05/18/2017 at 03:54:07 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 05/19/2017 at 11:39:10 AM by kzar
- Cc kzar trev sebastian fhd added
comment:5 Changed on 05/19/2017 at 03:51:22 PM by trev
- Priority changed from Unknown to P4
- Ready set
comment:6 Changed on 05/19/2017 at 06:21:29 PM by abpbot
comment:7 Changed on 05/19/2017 at 06:24:32 PM by abpbot
A commit referencing this issue has landed:
Issue 5257 - Add an eslint target to npm run and run it posttest.
comment:8 Changed on 05/19/2017 at 06:25:34 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5257 - Add an eslint target to npm run and run it posttest.