Opened on 06/28/2017 at 02:02:41 PM
Closed on 08/16/2017 at 02:44:45 PM
#5355 closed defect (fixed)
Fix line height on adblockplus.org
| Reported by: | ire | Assignee: | ire |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, wspee, saroyanm, jlow, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by ire)
How to reproduce
- Go to any text-heavy page, e.g. https://adblockplus.org/en/about
Observed behaviour
On most parts of the site, the text can be difficult to read because the line height is too small. There are a few cases where the line height has been corrected for specific elements, for example the list items on the home page (ul#features li), but this needs to be site-wide.
What to do
Set a line height for the entire site to 1.5
Attachments (0)
Change History (8)
comment:1 follow-up: ↓ 3 Changed on 07/12/2017 at 02:08:13 PM by juliandoucette
- Cc jlow added
- Priority changed from Unknown to P2
comment:2 Changed on 07/13/2017 at 08:08:37 AM by ire
- Cc ire added
comment:3 in reply to: ↑ 1 Changed on 07/18/2017 at 07:52:18 AM by ire
- Description modified (diff)
Replying to juliandoucette:
I suggest we follow the WCAG 2.0 recommendation of 1.5.
Okay. Updating the ticket.
comment:4 Changed on 07/24/2017 at 08:33:23 AM by ire
@jlow Can we ready this ticket?
comment:5 Changed on 07/31/2017 at 11:14:17 AM by ire
- Owner set to ire
- Ready set
comment:6 Changed on 08/04/2017 at 02:39:55 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 08/16/2017 at 02:43:58 PM by abpbot
A commit referencing this issue has landed:
Issue 5355 - Fix line height on adblockplus.org
comment:8 Changed on 08/16/2017 at 02:44:45 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I suggest we follow the WCAG 2.0 recommendation of 1.5.
@jlow we can mark this ready if you agree.