Opened on 06/28/2017 at 01:26:37 PM
Closed on 11/13/2017 at 08:54:15 PM
Last modified on 10/08/2019 at 05:52:51 PM
#5354 closed defect (fixed)
Notifications with buttons are not supported in Opera
| Reported by: | Ross | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | kzar, greiner, jsonesen, sebastian | Blocked By: | |
| Blocking: | Platform: | Opera | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
ABP 1.13.2.1785
Opera 36 / 49 / Window 7
How to reproduce
- Install ABP (to have default/clear preferences).
- Visit http://www.nexusmods.com/games
- Repeat Steps 2-3 in Chrome.
Observed behaviour
In Chrome, the anti-adblock notification appears as expected.
In Opera it does not and the following error appears in the extensions background page console:
_generated_background_page.html:1 Unchecked runtime.lastError while running notifications.create: Adding buttons to notifications is not supported.
Expected behaviour
If buttons are not supported, the notification should be displayed without buttons, except if the type of the notification is question in which case the notification should not be shown if buttons are not supported. Either way, no error should be logged.
Attachments (0)
Change History (17)
comment:1 Changed on 06/28/2017 at 01:29:02 PM by Ross
comment:2 Changed on 06/28/2017 at 01:41:23 PM by sebastian
- Cc kzar greiner jsonesen sebastian added
- Component changed from Unknown to Platform
- Priority changed from Unknown to P3
Yeah, generally, the notification should appear on Opera. But from reading the error message, I agree, it doesn't seem we can have buttons there, and without buttons this notification seems quite useless. Possibly, we could fallback to HTML notifications though. Either way we should get rid of the error.
comment:3 Changed on 07/11/2017 at 04:13:10 PM by kzar
- Ready set
comment:4 Changed on 10/02/2017 at 06:55:21 PM by jsonesen
- Owner set to jsonesen
comment:6 Changed on 10/04/2017 at 07:42:51 PM by sebastian
- Summary changed from Anti-adblock notification does not work in Opera to Notifications with buttons are not supported in Opera
comment:8 Changed on 10/18/2017 at 11:56:30 PM by jsonesen
Also, it looks like we will need to implement a html notification if we want them to appear on opera. However, deleting the button property does fix the issues with errors being thrown.
comment:9 Changed on 10/19/2017 at 01:21:04 AM by sebastian
- Description modified (diff)
There is already a fallback to HTML notifications, but it seems HTML notifications cannot have buttons either. So we don't use this fallback for notifications of the type question (e.g. the anti-adblock notification), and not if browser.notifications is supported anyway.
But then again, there is no point in showing the anti-adblock notification if we can not have buttons to opt-in or -out of that list. So if buttons aren't supported in browser.notifications and the notification type is question it seems best to not show the notification at all.
comment:10 Changed on 10/19/2017 at 09:58:39 PM by jsonesen
- Review URL(s) modified (diff)
comment:11 Changed on 11/02/2017 at 04:12:01 AM by abpbot
A commit referencing this issue has landed:
Issue 5354 - Adds handling for notifications with buttons in Opera
comment:12 Changed on 11/13/2017 at 08:54:15 PM by jsonesen
- Resolution set to fixed
- Status changed from new to closed
comment:13 Changed on 11/13/2017 at 09:00:57 PM by sebastian
- Milestone set to Adblock-Plus-3.0-for-Chrome-Opera-Firefox
comment:14 Changed on 03/23/2019 at 04:16:34 PM by Thanos
spam
comment:15 Changed on 05/16/2019 at 07:24:55 AM by Himanshu0709
spam
comment:16 Changed on 07/12/2019 at 07:35:04 AM by vedantydv123
spam
comment:17 Changed on 09/25/2019 at 04:49:29 AM by Henshaw34
spam
I'm not actually 100% sure if the anti-adblock notification should appear in Opera but the consensus seems to be be it should. The error seems to be related to a platform restriction (not able to add buttons to notifications) so I'm not sure if/how it worked if it did before.