Opened on 07/06/2017 at 12:03:53 PM
Closed on 10/02/2017 at 01:54:55 PM
#5379 closed defect (fixed)
Remove top level paths from acceptableads.com
| Reported by: | juliandoucette | Assignee: | juliandoucette |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | wspee, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by juliandoucette)
Environment
All
How to reproduce
- Search for href="/, src="/, (/
Observed behaviour
- See top level paths e.g. [link](/top-level) instead of [link](relative)
Expected behaviour
- Paths should be relative for testing and localization
Implementation details
I will implement this in two separate patchsets. One for hrefs, and another for srcs, because localized srcs are not supported by our cms test server.
Attachments (0)
Change History (8)
comment:2 Changed on 07/13/2017 at 08:33:55 AM by ire
- Cc ire added; iaderinokun removed
comment:3 Changed on 09/04/2017 at 11:16:54 AM by juliandoucette
- Owner set to juliandoucette
comment:4 Changed on 09/04/2017 at 11:31:51 AM by juliandoucette
comment:6 Changed on 09/11/2017 at 04:10:20 PM by abpbot
comment:7 Changed on 09/11/2017 at 04:10:51 PM by juliandoucette
Note: The previous commit only resolved hrefs not srcs.
comment:8 Changed on 10/02/2017 at 01:54:55 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
I'm closing this because we only need to localize (make not top level) image paths if images contain text that should be translated. And there are no such images on acceptableads.com.
(Half of this issue has been resolved. The other half was invalid.)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5379 - Corrected unlocalized hrefs in content