Opened on 07/06/2017 at 12:08:12 PM
Closed on 01/30/2018 at 11:46:09 PM
#5380 closed change (incomplete)
Remove styleguide page from acceptableads.com?
Reported by: | juliandoucette | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Websites | Keywords: | goodfirstbug |
Cc: | wspee, ire | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
The styleguide page is unlisted on acceptableads.com and we have not been maintaining it.
What to change
Remove this page and it's includes.
Attachments (0)
Change History (7)
comment:1 Changed on 07/06/2017 at 12:09:28 PM by juliandoucette
comment:2 follow-up: ↓ 3 Changed on 07/07/2017 at 09:08:43 AM by ire
I don't necessarily think it should be removed because we have not been maintaining it. But maybe it should be changed.
I think that perhaps the reason it has not been maintained much is because it seems to be a relatively "full-featured" style guide. It does not only include, like most style guides, basic things such as headings, colours, and some components like buttons. Instead, it seems to be more a guide that non-technical people can follow to build pages themselves. This may be more useful but is also more a hassle to maintain.
It may be simpler to have a more minimal style guide as a part of website-defaults that will include those basic elements that are on every site. For example, I can imagine having files like the headings.md one as part of website-defaults that could be included into a site's style guide. And if necessary, specific sites can have additional elements that are more specific to the site.
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed on 07/12/2017 at 03:37:21 PM by juliandoucette
Replying to iaderinokun:
It may be simpler to have a more minimal style guide as a part of website-defaults that will include those basic elements that are on every site. For example, I can imagine having files like the headings.md one as part of website-defaults that could be included into a site's style guide. And if necessary, specific sites can have additional elements that are more specific to the site.
Sounds good to me.
How do you feel about implementing such a website-defaults guide while you are implementing help center?
If you don't mind, we'll:
- Leave this be on acceptableads.com
- Implement a basic style guide in website-defaults
- Extend said basic guide in help center
- Extend said basic guide in acceptableads.com (if we ever get around to it)
And you can create the tickets for 2 and 3.
Note: We can't include directly from website-defaults yet via CMS. Therefore, you could include the one that will go into website-defaults in help center until this issue is resolved.
comment:4 in reply to: ↑ 3 Changed on 07/12/2017 at 04:39:55 PM by ire
Replying to juliandoucette:
Sounds good to me.
How do you feel about implementing such a website-defaults guide while you are implementing help center?
If you don't mind, we'll:
- Leave this be on acceptableads.com
- Implement a basic style guide in website-defaults
- Extend said basic guide in help center
- Extend said basic guide in acceptableads.com (if we ever get around to it)
And you can create the tickets for 2 and 3.
Note: We can't include directly from website-defaults yet via CMS. Therefore, you could include the one that will go into website-defaults in help center until this issue is resolved.
Sure sounds good.
comment:5 Changed on 07/13/2017 at 08:35:41 AM by ire
- Cc ire added; iaderinokun removed
comment:6 Changed on 12/20/2017 at 12:28:36 PM by ire
Since we implemented V1 of a styleguide page in #5413, I think we can remove the aa custom styleguide pages, and improve the one in wd
comment:7 Changed on 01/30/2018 at 11:46:09 PM by juliandoucette
- Resolution set to incomplete
- Status changed from new to closed
I agree. Thank you for your feedback. I will wait until the new styleguide is fully implemented before removing this one though. It may be useful yet. Let's tackle this / styleguide integration separately on Gitlab.
I'm not sure if/how we could/should integrate such a page into website-defaults and/or individual websites.
What do you think Ire?