Opened on 07/12/2017 at 10:41:21 PM
Closed on 08/17/2017 at 02:49:12 PM
Last modified on 10/02/2017 at 10:32:18 PM
#5411 closed defect (fixed)
Undefined var MOZ_ANDROID_GCM_SENDERID
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Since we don't define MOZ_ANDROID_GCM_SENDERID in our confvars.sh, the project fails to build in abb_fennec_53_0_2_merge with the following message:
mozbuild.preprocessor.Error: ('/Users/dlima/Workspace/adblockbrowser/mobile/android/app/mobile.js', 917, 'UNDEFINED_VAR', 'MOZ_ANDROID_GCM_SENDERID')
We need to either define a value for MOZ_ANDROID_GCM_SENDERID or remove it from mobile.js
Attachments (0)
Change History (6)
comment:1 Changed on 07/13/2017 at 03:54:38 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/07/2017 at 09:36:15 PM by abpbot
comment:3 Changed on 08/17/2017 at 02:49:12 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 09/28/2017 at 02:15:22 PM by traynard
If this item is testable, please provide some testing information/instructions
comment:5 Changed on 09/28/2017 at 07:43:23 PM by diegocarloslima
@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.
comment:6 Changed on 10/02/2017 at 10:32:18 PM by traynard
- Verified working set
@diegocarloslima: Thanks, marking as verified working.
A commit referencing this issue has landed:
Issue 5411 - Undefined var MOZ_ANDROID_GCM_SENDERID