Duplicates not allowed when packaging ABP

[diegocarloslima]

Mozilla changed how thefind-dupes.py works, starting in Firefox 52. Now it produces a error instead of a warning if it finds duplicate files while packaging (More info in the following tickets ​1303184, ​1313640 and ​1313670). Given that, it now produces an error when building abb_fennec_53_0_2_merge, complaining about the common.properties and common.js files in Adblock Plus. Following is the full error log:

ERROR: The following duplicated files are not allowed:
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ar/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/az/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/bg/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ca/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/cs/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/cy/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/da/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/de/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/dsb/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/el/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/en-GB/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/en-US/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/en-ZA/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/eo/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/es-AR/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/es-CL/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/es-ES/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/es-MX/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/et/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/eu/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/fa/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/fi/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/fr/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/fy-NL/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/gl/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/he/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/hr/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/hsb/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/hu/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/hy-AM/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/id/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/is/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/it/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ja/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/kk/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ko/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/lt/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/lv/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ms/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/nb-NO/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/nl/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/pl/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/pt-BR/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/pt-PT/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ro/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/ru/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/sk/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/sl/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/sq/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/sr/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/sv-SE/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/th/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/tr/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/uk/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/vi/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/zh-CN/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/zh-TW/common.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/az/firstRun.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/en-US/firstRun.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/locale/en-ZA/firstRun.properties
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/chrome/content/ui/ext/common.js
extensions/{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}/lib/ext_common.js

In order to fix that, we can either remove the duplicate files or add them as an exception in allowed-dupes.mn file

[abpbot]

A commit referencing this issue has landed:
​Issue 5412 - Duplicates not allowed when packaging ABP

[traynard]

If this item is testable, please provide some testing information/instructions

[diegocarloslima]

@traynard: This error message is related to a build issue. As I mentioned in other tickets, the fact that I was able to build the project in order to generate the release candidate .apk, might be enough to consider the build time error as verified working. Additionally, since this issue was related to the installation of the ABP extension, you can check if the Ad blocking settings, which communicates with the ABP extension, is working as expected.