Opened on 07/19/2017 at 03:46:41 PM

Closed on 08/15/2017 at 02:59:04 PM

Last modified on 08/15/2017 at 03:02:19 PM

#5431 closed defect (fixed)

Prevent update_copyright test from being overwritten when the script is run

Reported by: rhowell Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29493601

Description

Background

When the script runs to update the copyrights each year, it will also find and update the sample_file.py, thus rendering the test page useless.

What to change

codingtools/update-copyright/tests/data/sample_file.py
Adjust the formatting to generate the file programmatically, so it doesn't match the expression that the script is looking for.

Attachments (0)

Change History (4)

comment:1 Changed on 07/19/2017 at 04:06:20 PM by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 08/07/2017 at 08:34:28 PM by abpbot

A commit referencing this issue has landed:
​Issue 5431 - Fix test for copyright update script

comment:3 Changed on 08/15/2017 at 02:59:04 PM by rhowell

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed on 08/15/2017 at 03:02:19 PM by sebastian

  • Review URL(s) modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rhowell.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.