Opened on 07/19/2017 at 03:53:40 PM
Closed on 08/17/2017 at 02:50:01 PM
Last modified on 10/04/2017 at 10:18:01 PM
#5432 closed defect (fixed)
No android_package_name string resource found
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Mozilla has changed the minSdk from 9 to 15 (More info here, here and here) and with that, they are using android:fragment instead of intent in all preferences files, that's why they removed the android_package_name string resource that was used in the android:targetPackage attribute. This is causing abb_fennec_53_0_2_mergebuild to fail with the following message:
/Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:19: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name'). /Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:28: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name'). /Users/dlima/Workspace/adblockbrowser/mobile/android/base/resources/xml/preferences_abb_abp.xml:40: error: Error: No resource found that matches the given name (at 'targetPackage' with value '@string/android_package_name').
To fix that, it seems that we can pretty much just replace our preferences from xml-v11 into the xml folder.
Attachments (0)
Change History (7)
comment:2 Changed on 07/19/2017 at 04:13:13 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/07/2017 at 09:45:27 PM by abpbot
comment:4 Changed on 08/17/2017 at 02:50:01 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/28/2017 at 02:28:16 PM by traynard
If this item is testable, please provide some testing information/instructions
comment:6 Changed on 09/28/2017 at 07:55:00 PM by diegocarloslima
@traynard: This error message is related to a build issue. As I mentioned in other tickets, the fact that I was able to build the project in order to generate the release candidate .apk, might be enough to consider the build time error as verified working. Additionally, since this issue was related to the layout of the Ad blocking settings screen, you can check if it's being displayed as expected.
comment:7 Changed on 10/04/2017 at 10:18:01 PM by traynard
- Verified working set
layout and functionality of Ad blocking settings screen is same as 1.2.0
A commit referencing this issue has landed:
Issue 5432 - No android_package_name string resource found