Opened on 08/07/2017 at 12:10:22 PM
Closed on 08/22/2017 at 02:23:42 PM
#5473 closed change (fixed)
Update to use libadblockplus revision b4d6e55f2116
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | asmirnov | Blocked By: | |
Blocking: | #5266 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29503591/ |
Description
Background
Beside other things the new version of libadblockplus uses android NDK 12b and there are almost no changes in the public API of libadblockplus until this revision.
The list of changes imported by this is:
Ticket | Summary | Component |
---|---|---|
#5433 | Allow to specify external prebuilt v8 while compiling libadblockplus | Libadblockplus |
#5378 | Stop using of jshydra in libadblockplus | Libadblockplus |
#5183 | Make interface of FileSystem asynchronous | Libadblockplus |
#5119 | use own version of buildtools for ensure_deps instead of a version from adblockpluscore | Libadblockplus |
#4907 | Update v8 to 5.7.278 in libadblockplus | Libadblockplus |
b4d6e55f2116 | Noissue - don't throw a pointer to an exception in C++ | Sergei Zabolotskikh |
0f144e401672 | Noissue - move anonymous namespace from header to cpp file | Sergei Zabolotskikh |
16ea1ae3347d | Noissue - synchronize usage of struct and class | Sergei Zabolotskikh |
35e4ccd3b140 | Noissue - remove unnecessary including of v8.h | Sergei Zabolotskikh |
094e2850704b | Noissue - move host detecting script into libadblockplus repo | Sergei Zabolotskikh |
193cb0a8b53e | Noissue - remove obsolete part of a comment | Sergei Zabolotskikh |
451ff2c10f78 | Noissue - fix headers in order to compile on MS Windows | Sergei Zabolotskikh |
ebd2573db477 | Noissue - Use buffer for FileSystem IO | Hubert Figuière |
4932fd217b7d | Noissue - Fix some execution order issues in the prefs initialisation | Hubert Figuière |
dd95ab67d425 | Noissue - fix typo "dowload" to "download" (n is absent) | Sergei Zabolotskikh |
What to change
Prepare and update libadblockplus-binaries dependency to libadblockplus hg:b4d6e55f2116 revision as well as adapt the code.
Attachments (0)
Change History (6)
comment:3 Changed on 08/08/2017 at 05:13:33 AM by abpbot
comment:4 Changed on 08/08/2017 at 11:44:17 AM by sergz
- Blocking 5266 added
comment:5 Changed on 08/09/2017 at 06:55:35 AM by abpbot
A commit referencing this issue has landed:
Issue 5473 - update to libadblockplus revision b4d6e55f2116
comment:6 Changed on 08/22/2017 at 02:23:42 PM by sergz
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5473 - Update to use libadblockplus revision b4d6e55f2116