Opened on 08/07/2017 at 03:12:09 PM

Closed on 08/22/2017 at 08:23:46 AM

#5477 closed defect (fixed)

Buildtool doesn't import localization string placeholders on build

Reported by:	saroyanm	Assignee:	tlucas
Priority:	P2	Milestone:
Module:	Automation	Keywords:
Cc:	sebastian, greiner, kzar, tlucas	Blocked By:
Blocking:	#5158	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29517660/

Description (last modified by tlucas)

Environment

As defined here

How to reproduce

Clone adblockplus repository
Add line below into metadate.chrome to the [import_locales] section:
```
adblockplusui/locale/*/new-options.json = =*
```

Run ./build.py -t chrome devenv
Import generated extension into chrome browser
Observe

Observed behaviour

Current error is being thrown:

Variable $domain$ used but not defined.

Expected behaviour

No error is thrown and corresponding placeholder is being imported into generated locale/*/messages.json file.

What to test

Importing gecko-locales still as expected
Escaping string names (IDs) as expected (see git-commit fc0b3313 / 3f614288 )

Change History (9)

comment:1 Changed on 08/07/2017 at 03:19:04 PM by saroyanm

Cc sebastian greiner kzar added

So far only this issue is noticed after testing new options page in the production environment.

If you guys can check this out, I will highly appreciate that.

Last edited on 08/07/2017 at 03:19:50 PM by saroyanm

comment:2 Changed on 08/07/2017 at 04:12:31 PM by saroyanm

Summary changed from Buildtool doesn't import placeholders to Buildtool doesn't import localization string placeholders on build

comment:3 Changed on 08/07/2017 at 04:17:52 PM by tlucas

Cc tlucas added

comment:4 Changed on 08/15/2017 at 01:57:53 PM by sebastian

Priority changed from Unknown to P2
Ready set

comment:5 Changed on 08/16/2017 at 10:24:36 AM by tlucas

Owner set to tlucas

comment:6 Changed on 08/16/2017 at 02:11:19 PM by tlucas

Description modified (diff)

comment:7 Changed on 08/16/2017 at 02:22:45 PM by tlucas

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:8 Changed on 08/22/2017 at 08:21:49 AM by abpbot

A commit referencing this issue has landed:
Issue 5477 - Import everything from imported locales

comment:9 Changed on 08/22/2017 at 08:23:46 AM by tlucas

Resolution set to fixed
Status changed from reviewing to closed

Context Navigation