Opened on 08/09/2017 at 11:10:11 AM

Closed on 08/28/2017 at 12:09:31 PM

#5482 closed change (fixed)

Implement Sidebar styles and about ABP dialog

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #5158, #5548 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29502647/

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158).

What to change

Implement the about dialog as defined ​here and implement sidebar styles as defined ​here.

Attachments (0)

Change History (5)

comment:1 Changed on 08/09/2017 at 11:15:12 AM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 08/21/2017 at 10:49:46 AM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/21/2017 at 10:51:15 AM by saroyanm

  • Blocking 5548 added

comment:4 Changed on 08/28/2017 at 12:07:35 PM by abpbot

A commit referencing this issue has landed:
​Issue 5482 - Sidebar and about ABP dialog

comment:5 Changed on 08/28/2017 at 12:09:31 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.