Opened on 08/09/2017 at 01:26:11 PM
Closed on 08/30/2019 at 04:01:37 PM
#5483 closed change (rejected)
Complete test-coverage for Build-and-Release-Tools
| Reported by: | tlucas | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, kzar, kvas | Blocked By: | |
| Blocking: | #5484 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by tlucas)
Background
With python2.x loosing support sometime in 2020, we want to have a decent test-coverage of the modules currently running on python2.x, before switching to python3 compatibility.
What to change
Provide tests for publicly used functionalities in the Build-and-Release-tools, which are not yet covered by #5383 and #4028, namely:
- the commands in build.py
- ensure_dependencies.py
- xarfile.py
Attachments (0)
Change History (10)
comment:1 Changed on 08/09/2017 at 01:31:46 PM by tlucas
- Blocking 5484 added
comment:3 Changed on 08/09/2017 at 02:27:02 PM by kzar
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 08/10/2017 at 07:51:04 AM by tlucas
- Owner set to tlucas
comment:5 Changed on 08/10/2017 at 01:58:06 PM by kzar
- Summary changed from Complete test-coverade for Build-and-Release-Tools to Complete test-coverage for Build-and-Release-Tools
comment:7 in reply to: ↑ 6 Changed on 08/11/2017 at 12:55:25 PM by tlucas
Replying to sebastian:
More importantly than testing the internal APIs of buildtools, we should test the build commands.
I agree - i will add this to the implementation as well.
comment:8 Changed on 08/14/2017 at 02:58:02 PM by tlucas
- Description modified (diff)
Changed the description in order to adhere to what was discussed in IRC
comment:9 Changed on 08/15/2017 at 02:41:43 PM by tlucas
- Owner tlucas deleted
Reset assignee: i'm currently not working on this
comment:10 Changed on 08/30/2019 at 04:01:37 PM by sebastian
- Resolution set to rejected
- Status changed from new to closed
Rejecting this issue now as buildtools is in maintenance mode and will eventually be discontinued.
More importantly than testing the internal APIs of buildtools, we should test the build commands.