Opened on 08/11/2017 at 02:29:44 PM
Closed on 09/05/2017 at 12:24:48 PM
Last modified on 10/21/2017 at 04:26:52 AM
#5507 closed change (fixed)
Download only translated files from Crowdin
| Reported by: | diegocarloslima | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Currently, we use our translations.py script to fetch all translations files from Crowdin. The issue is that it also fetches some locales that haven't been translated yet (e.g. Armenian , hy-AM)
What to change
See if its possible to only fetch the files that have at least something translated
Attachments (1)
Change History (9)
comment:1 Changed on 08/11/2017 at 02:31:21 PM by jwangenheim
- Owner set to jwangenheim
comment:2 Changed on 08/14/2017 at 01:20:33 PM by jwangenheim
Last edited on 08/15/2017 at 12:02:55 PM
by jwangenheim
comment:4 Changed on 08/15/2017 at 02:18:37 PM by jwangenheim
- Status changed from new to reviewing
comment:5 Changed on 09/05/2017 at 12:23:41 PM by abpbot
A commit referencing this issue has landed:
Issue 5507 - Download only translated files from Crowdin
comment:6 Changed on 09/05/2017 at 12:24:48 PM by jwangenheim
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
Changed on 10/11/2017 at 10:48:43 PM by traynard
English (UK) Search Engine list
comment:7 Changed on 10/11/2017 at 10:49:29 PM by traynard
oops attached above screenshot to the wrong ticket. Please ignore
comment:8 Changed on 10/21/2017 at 04:26:52 AM by traynard
- Verified working set
Note: See
TracTickets for help on using
tickets.
It is possible to check the translation progress with the crowdin API, but we can either fetch the translations for ONE or ALL languages.
I will extend translations.py with a method that returns a dictionary of all locales with their translation_progress and subsequently ignores the languages that haven't been translated yet.