Opened on 08/11/2017 at 01:50:24 PM
Closed on 09/12/2017 at 05:14:05 PM
#5506 closed change (fixed)
Fix Notification test
| Reported by: | sergz | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29525558 |
||
Description
Background
Currently we have a disabled by #ifdef notification test because there is no way to inject some hard coded values in notification.js. This test often gets obsolete and not compilable, so it should have DISABLED_ prefix and be always compilable.
In addition, please consider a way to actually inject the required values.
Attachments (0)
Change History (7)
comment:1 Changed on 08/23/2017 at 04:59:28 PM by hfiguiere
- Owner set to hfiguiere
- Review URL(s) modified (diff)
comment:2 Changed on 08/23/2017 at 04:59:36 PM by hfiguiere
- Status changed from new to reviewing
comment:3 Changed on 08/24/2017 at 12:58:31 AM by abpbot
comment:4 Changed on 09/07/2017 at 10:16:40 PM by hfiguiere
Currently the test is disabled, so it gets compiled. Next step is to fix it.
Last edited on 09/07/2017 at 10:33:03 PM
by hfiguiere
comment:6 Changed on 09/12/2017 at 05:13:08 PM by abpbot
A commit referencing this issue has landed:
Issue 5506 - Make the notification test work.
comment:7 Changed on 09/12/2017 at 05:14:05 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5506 - Fix notification test