Opened on 08/20/2017 at 09:06:18 PM

Closed on 09/09/2019 at 03:36:38 PM

#5549 closed change (fixed)

Implement missing error handlings for custom filter lists

Reported by: saroyanm Assignee: agiammarchi
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29674584/

Description (last modified by saroyanm)

Background

After several design iterations we finally have a final version of the new options page (See #5158)

What to change

Implement error handling for the Advanced tab: Invalid custom filter.

Attachments (0)

Change History (7)

comment:1 Changed on 09/18/2017 at 12:27:46 PM by saroyanm

  • Description modified (diff)
  • Summary changed from Implement missing error handlings to Implement missing error handlings for custom filter lists

Add custom filter list dialog error handling will be implemented in #5706

comment:2 Changed on 09/26/2017 at 05:04:21 PM by saroyanm

We decided this is not crucial for First Viable Product launch as we don't handle this case in current options page of Chrome using "row" view.

comment:3 Changed on 09/26/2017 at 05:04:31 PM by saroyanm

  • Blocking 5158 removed

comment:4 Changed on 01/18/2018 at 04:26:55 PM by agiammarchi

  • Owner set to agiammarchi

comment:5 Changed on 01/23/2018 at 09:48:09 AM by saroyanm

  • Description modified (diff)

Update the link to point to the specs in Gitlab, as we moved there lately.

comment:6 Changed on 01/26/2018 at 06:01:23 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 09/09/2019 at 03:36:38 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing this ticket because filter error handling should now work as expected, thanks to the custom filter table redesign in ui#15 and the various fixes in ui#466.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from agiammarchi.
 
Note: See TracTickets for help on using tickets.