Opened on 08/22/2017 at 09:19:59 AM
Closed on 08/22/2017 at 11:20:46 AM
Last modified on 09/25/2017 at 11:18:23 AM
#5553 closed change (fixed)
Update buildtools dependency to hg:9c8d2c9e4344
Reported by: | tlucas | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-1.13.4-for-Chrome-Opera |
Module: | Platform | Keywords: | |
Cc: | sebastian, kzar | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description (last modified by tlucas)
Background
Some minor improvements were made and a Gecko-WebExtension-blocker was fixed ( #5477 ). We need to update the buildtools dependency in adblockpluschrome accordingly.
What to change
Upgrade the buildtools dependency in adblockpluschrome to:
hg | git |
9c8d2c9e4344 | 40e80b4 |
Included changes
64e5f6c97e81 | Noissue - Remove some dead code | Wladimir Palant |
Hints for testers
- Modularized locales should now be imported along with their metadata ( #5477 , adjust metadata accordingly)
- If a content_security_policy is included in metadata.chrome, it should now be included in the generated manifest ( see CSP )
- A qunit-folder should now only exist in devenv-builds
- Folders should now be created for files in the metadata's [mapping]-section, for target-folders which do not initially exist
Attachments (0)
Change History (7)
comment:2 Changed on 08/22/2017 at 11:01:05 AM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 08/22/2017 at 11:05:41 AM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/22/2017 at 11:19:14 AM by abpbot
comment:5 Changed on 08/22/2017 at 11:20:46 AM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/05/2017 at 10:18:35 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:7 Changed on 09/25/2017 at 11:18:23 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Verifying this for the milestone as working builds are created successfully. Will go over child tickets this week.
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5553 - Updating buildtools dependency to hg:9c8d2c9e4344